feat: Initial implementation of size for array inputs #2862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2862 +/- ##
============================================
+ Coverage 56.12% 59.61% +3.48%
- Complexity 976 1381 +405
============================================
Files 119 167 +48
Lines 11743 15502 +3759
Branches 2251 2570 +319
============================================
+ Hits 6591 9241 +2650
- Misses 4012 4960 +948
- Partials 1140 1301 +161 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
changed the title
Contributor
|
Member
Author
|
@comphead please take another look when you can |
comphead
approved these changes
Dec 23, 2025
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
Thanks @andygrove it is LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Partially implements #1926 (supports arrays but not maps)
Rationale for this change
sizeis a widely used SQL function in Spark.What changes are included in this PR?
How are these changes tested?